]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
soc: qcom: rmtfs-mem: Add class to enable uevents
authorEvan Green <evgreen@chromium.org>
Thu, 3 Jan 2019 00:02:12 +0000 (16:02 -0800)
committerAndy Gross <andy.gross@linaro.org>
Fri, 1 Feb 2019 22:08:27 +0000 (16:08 -0600)
Currently the qcom_rmtfs_memN devices are entirely invisible to the udev world.
Add a class to the rmtfs device so that uevents fire when the device is added.

Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/soc/qcom/rmtfs_mem.c

index 97bb5989aa21158dee92d58e5f22bc74729dbbc2..b2fa8fc8016c0028ac258fab2db0758bca57e062 100644 (file)
@@ -132,6 +132,11 @@ static int qcom_rmtfs_mem_release(struct inode *inode, struct file *filp)
        return 0;
 }
 
+static struct class rmtfs_class = {
+       .owner          = THIS_MODULE,
+       .name           = "rmtfs",
+};
+
 static const struct file_operations qcom_rmtfs_mem_fops = {
        .owner = THIS_MODULE,
        .open = qcom_rmtfs_mem_open,
@@ -199,6 +204,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
 
        dev_set_name(&rmtfs_mem->dev, "qcom_rmtfs_mem%d", client_id);
        rmtfs_mem->dev.id = client_id;
+       rmtfs_mem->dev.class = &rmtfs_class;
        rmtfs_mem->dev.devt = MKDEV(MAJOR(qcom_rmtfs_mem_major), client_id);
 
        ret = cdev_device_add(&rmtfs_mem->cdev, &rmtfs_mem->dev);
@@ -277,32 +283,42 @@ static struct platform_driver qcom_rmtfs_mem_driver = {
        },
 };
 
-static int qcom_rmtfs_mem_init(void)
+static int __init qcom_rmtfs_mem_init(void)
 {
        int ret;
 
+       ret = class_register(&rmtfs_class);
+       if (ret)
+               return ret;
+
        ret = alloc_chrdev_region(&qcom_rmtfs_mem_major, 0,
                                  QCOM_RMTFS_MEM_DEV_MAX, "qcom_rmtfs_mem");
        if (ret < 0) {
                pr_err("qcom_rmtfs_mem: failed to allocate char dev region\n");
-               return ret;
+               goto unregister_class;
        }
 
        ret = platform_driver_register(&qcom_rmtfs_mem_driver);
        if (ret < 0) {
                pr_err("qcom_rmtfs_mem: failed to register rmtfs_mem driver\n");
-               unregister_chrdev_region(qcom_rmtfs_mem_major,
-                                        QCOM_RMTFS_MEM_DEV_MAX);
+               goto unregister_chrdev;
        }
 
+       return 0;
+
+unregister_chrdev:
+       unregister_chrdev_region(qcom_rmtfs_mem_major, QCOM_RMTFS_MEM_DEV_MAX);
+unregister_class:
+       class_unregister(&rmtfs_class);
        return ret;
 }
 module_init(qcom_rmtfs_mem_init);
 
-static void qcom_rmtfs_mem_exit(void)
+static void __exit qcom_rmtfs_mem_exit(void)
 {
        platform_driver_unregister(&qcom_rmtfs_mem_driver);
        unregister_chrdev_region(qcom_rmtfs_mem_major, QCOM_RMTFS_MEM_DEV_MAX);
+       class_unregister(&rmtfs_class);
 }
 module_exit(qcom_rmtfs_mem_exit);