]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf/core: Remove bogus UP_CANCELED hotplug state
authorThomas Gleixner <tglx@linutronix.de>
Tue, 9 Feb 2016 20:11:20 +0000 (20:11 +0000)
committerIngo Molnar <mingo@kernel.org>
Wed, 17 Feb 2016 09:37:28 +0000 (10:37 +0100)
If CPU_UP_PREPARE fails the perf hotplug code calls perf_event_exit_cpu(),
which is a pointless exercise. The cpu is not online, so the smp function
calls return -ENXIO. So the result is a list walk to call noops.

Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/20160209201007.682184765@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/core.c

index 5946460b24250a264f75c442099bb52ca06b0269..474ffeafe363dfefc63efe5919bcffacfd6d193d 100644 (file)
@@ -9286,7 +9286,6 @@ perf_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu)
                perf_event_init_cpu(cpu);
                break;
 
-       case CPU_UP_CANCELED:
        case CPU_DOWN_PREPARE:
                perf_event_exit_cpu(cpu);
                break;