]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: stm32-dcmi: do not fall into error on buffer starvation
authorHugues Fruchet <hugues.fruchet@st.com>
Mon, 11 Jun 2018 09:50:24 +0000 (05:50 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 28 Jun 2018 11:45:40 +0000 (07:45 -0400)
Return silently instead of falling into error when running
out of available buffers when restarting capture.
Capture will be restarted when new buffers will be
provided by V4L2 client.

Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/stm32/stm32-dcmi.c

index b78583dc972b11474c2d1dbe12707fd58c69cada..fc72a57d84782e0df51e0cf3b4ece71838626ef3 100644 (file)
@@ -227,13 +227,10 @@ static int dcmi_restart_capture(struct stm32_dcmi *dcmi)
 
        /* Restart a new DMA transfer with next buffer */
        if (list_empty(&dcmi->buffers)) {
-               dev_err(dcmi->dev, "%s: No more buffer queued, cannot capture buffer\n",
-                       __func__);
-               dcmi->errors_count++;
+               dev_dbg(dcmi->dev, "Capture restart is deferred to next buffer queueing\n");
                dcmi->active = NULL;
-
                spin_unlock_irq(&dcmi->irqlock);
-               return -EINVAL;
+               return 0;
        }
 
        dcmi->active = list_entry(dcmi->buffers.next,