]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/nouveau/bar/gm20b: Avoid BAR1 teardown during init
authorThierry Reding <treding@nvidia.com>
Mon, 16 Sep 2019 14:19:26 +0000 (16:19 +0200)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 17 Sep 2019 04:50:16 +0000 (14:50 +1000)
Writing the 0x1704 (BUS_BAR1_BLOCK) register causes the GPU to probe the
memory region at the programmed address. The result is an address decode
error in the external memory controller because address 0, which is what
is written to the register, is not designated as accessible to devices.

Avoid triggering DMA from the GPU by removing teardown of the BAR1.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nvkm/subdev/bar/gm20b.c

index 950bff1955ad484da20c16f1623439ed72b79586..1ed6170891c4285d9a5408c4e0d445b42a5c3c01 100644 (file)
@@ -26,7 +26,6 @@ gm20b_bar_func = {
        .dtor = gf100_bar_dtor,
        .oneinit = gf100_bar_oneinit,
        .bar1.init = gf100_bar_bar1_init,
-       .bar1.fini = gf100_bar_bar1_fini,
        .bar1.wait = gm107_bar_bar1_wait,
        .bar1.vmm = gf100_bar_bar1_vmm,
        .flush = g84_bar_flush,