]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: zte: spdif: remove duplicate initialization of dma_data
authorColin Ian King <colin.king@canonical.com>
Mon, 18 Sep 2017 08:56:38 +0000 (09:56 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 19 Sep 2017 11:56:50 +0000 (12:56 +0100)
dma_data is being initialized twice, remove the unused first
initialization and use the latter one instead.  Fixed clang warning:

"warning: Value stored to 'dma_data' during its initialization is
never read"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/zte/zx-spdif.c

index b143f9f682d2f6e9c889a1dc2dc81b79b6fd504d..17b6ce35037a8042c5281961f35b649456061101 100644 (file)
@@ -139,11 +139,11 @@ static int zx_spdif_hw_params(struct snd_pcm_substream *substream,
 {
        struct zx_spdif_info *zx_spdif = dev_get_drvdata(socdai->dev);
        struct zx_spdif_info *spdif = snd_soc_dai_get_drvdata(socdai);
-       struct snd_dmaengine_dai_dma_data *dma_data = &zx_spdif->dma_data;
+       struct snd_dmaengine_dai_dma_data *dma_data =
+               snd_soc_dai_get_dma_data(socdai, substream);
        u32 val, ch_num, rate;
        int ret;
 
-       dma_data = snd_soc_dai_get_dma_data(socdai, substream);
        dma_data->addr_width = params_width(params) >> 3;
 
        val = readl_relaxed(zx_spdif->reg_base + ZX_CTRL);