]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/rockchip: add extcon dependency for DP
authorArnd Bergmann <arnd@arndb.de>
Tue, 14 Feb 2017 21:31:51 +0000 (22:31 +0100)
committerSean Paul <seanpaul@chromium.org>
Thu, 23 Feb 2017 16:09:45 +0000 (11:09 -0500)
The newly added DP driver links against the extcon core, which fails when
extcon is a module and this driver is not:

drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'

Let's make Kconfig enforce correct behavior with a dependency.

Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Acked-by: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20170214213215.2888509-1-arnd@arndb.de
drivers/gpu/drm/rockchip/Kconfig

index ad31b3eb408fdee2138b6144c8d647bd9877b7fc..0e4eb845cbb0f5911a9e89bd2346cf62f006c4af 100644 (file)
@@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
 config ROCKCHIP_CDN_DP
         tristate "Rockchip cdn DP"
         depends on DRM_ROCKCHIP
+       depends on EXTCON
        select SND_SOC_HDMI_CODEC if SND_SOC
         help
          This selects support for Rockchip SoC specific extensions