]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ALSA: hda: Abort capability probe on invalid capability
authorRakesh Ughreja <rakesh.a.ughreja@intel.com>
Tue, 24 Oct 2017 12:56:47 +0000 (18:26 +0530)
committerTakashi Iwai <tiwai@suse.de>
Tue, 24 Oct 2017 06:13:55 +0000 (08:13 +0200)
On reading wrong capability pointer values driver may crash, so whenever
driver discovers unknown HDA capability, log it as error and stop traversing
the link list further.

Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/hdac_controller.c

index 978dc1801b3aceb8e2245b819097954c76595d77..8f7d0d9ed76209d68c955d6abd5e8f6b7a8ca183 100644 (file)
@@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus)
                        break;
 
                default:
-                       dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap);
+                       dev_err(bus->dev, "Unknown capability %d\n", cur_cap);
+                       cur_cap = 0;
                        break;
                }