]> asedeno.scripts.mit.edu Git - PuTTY.git/commitdiff
Remove redundant check for NULL in sshfwd_close(). The thing we're
authorSimon Tatham <anakin@pobox.com>
Thu, 9 Sep 2010 14:35:16 +0000 (14:35 +0000)
committerSimon Tatham <anakin@pobox.com>
Thu, 9 Sep 2010 14:35:16 +0000 (14:35 +0000)
testing against NULL has already been dereferenced by the time we
bother to test it, so it's a bit pointless - and in any case, no
null pointer can come to this function from any existing call site.

[originally from svn r8990]

ssh.c

diff --git a/ssh.c b/ssh.c
index 43d642dd1c97aa3abc7357efd3c1f127524063ce..401706c4057c9022e130cc72883d5db36c4b7ae4 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -4164,7 +4164,7 @@ void sshfwd_close(struct ssh_channel *c)
     if (ssh->state == SSH_STATE_CLOSED)
        return;
 
-    if (c && !c->closes) {
+    if (!c->closes) {
        /*
         * If halfopen is true, we have sent
         * CHANNEL_OPEN for this channel, but it hasn't even been