]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
firmware: raspberrypi: notify VC4 firmware of a reboot
authorStefan Wahren <stefan.wahren@i2se.com>
Fri, 7 Dec 2018 18:21:11 +0000 (19:21 +0100)
committerStefan Wahren <stefan.wahren@i2se.com>
Wed, 9 Jan 2019 15:38:34 +0000 (16:38 +0100)
The firmware-owned GPIO expander on RPi 3 B+ must be in same state
after a reboot as initial power on. Otherwise this would cause a
network boot failure of the BOOTROM. So inform the VC4 firmware to restore
the expander before doing a reboot.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Phil Elwell <phil@raspberrypi.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
drivers/firmware/raspberrypi.c

index a13558154ac305fc19e3dee687e07ea26e7c6f25..61be15d9df7dc2737ab4d1841356de4004e75836 100644 (file)
@@ -238,6 +238,16 @@ static int rpi_firmware_probe(struct platform_device *pdev)
        return 0;
 }
 
+static void rpi_firmware_shutdown(struct platform_device *pdev)
+{
+       struct rpi_firmware *fw = platform_get_drvdata(pdev);
+
+       if (!fw)
+               return;
+
+       rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_REBOOT, NULL, 0);
+}
+
 static int rpi_firmware_remove(struct platform_device *pdev)
 {
        struct rpi_firmware *fw = platform_get_drvdata(pdev);
@@ -278,6 +288,7 @@ static struct platform_driver rpi_firmware_driver = {
                .of_match_table = rpi_firmware_of_match,
        },
        .probe          = rpi_firmware_probe,
+       .shutdown       = rpi_firmware_shutdown,
        .remove         = rpi_firmware_remove,
 };
 module_platform_driver(rpi_firmware_driver);