]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/exynos/hdmi: Don't print error on deferral due to regulators
authorJavier Martinez Canillas <javier@osg.samsung.com>
Thu, 21 Apr 2016 18:51:38 +0000 (14:51 -0400)
committerInki Dae <daeinki@gmail.com>
Tue, 10 May 2016 14:11:44 +0000 (23:11 +0900)
The regulators may not be available just because their driver's probe
function was just not executed and so the regulators not registered.

So, in this case the Exynos HDMI driver should not print logs since
a -EPROBE_DEFER is not really an error and that will just pollute
the kernel log and confuse users.

This patch prevents the following misleading messages to be printed:

[    1.443638] [drm:hdmi_probe] *ERROR* failed to get regulators
[    1.449326] [drm:hdmi_probe] *ERROR* hdmi_resources_init failed

Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_hdmi.c

index 7de4dd5ab6e5e9859f41aab96cd3e77a8c0a1c5e..6cd09944405f3d941a37a600d3d6a9f340a442dd 100644 (file)
@@ -1683,7 +1683,8 @@ static int hdmi_resources_init(struct hdmi_context *hdata)
        }
        ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(supply), hdata->regul_bulk);
        if (ret) {
-               DRM_ERROR("failed to get regulators\n");
+               if (ret != -EPROBE_DEFER)
+                       DRM_ERROR("failed to get regulators\n");
                return ret;
        }
 
@@ -1806,7 +1807,8 @@ static int hdmi_probe(struct platform_device *pdev)
 
        ret = hdmi_resources_init(hdata);
        if (ret) {
-               DRM_ERROR("hdmi_resources_init failed\n");
+               if (ret != -EPROBE_DEFER)
+                       DRM_ERROR("hdmi_resources_init failed\n");
                return ret;
        }