]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: qla2xxx: check for kstrtol() failure
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 20 Feb 2019 05:39:13 +0000 (08:39 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 7 Mar 2019 00:26:46 +0000 (19:26 -0500)
The error handling was unintentionally left out so it introduces a Smatch
static checker warning:

    drivers/scsi/qla2xxx/qla_attr.c:1655 qla2x00_port_speed_store()
    error: uninitialized symbol 'type'.

Fixes: a7b9ca7fc87a ("scsi: qla2xxx: Add support for setting port speed")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_attr.c

index f8fd482a06e0c9a03f92e71260068399ad136ade..41734efe4bf93f863ca28adf299cdbb68100a216 100644 (file)
@@ -1652,6 +1652,8 @@ qla2x00_port_speed_store(struct device *dev, struct device_attribute *attr,
        }
 
        rval = kstrtol(buf, 10, &type);
+       if (rval)
+               return rval;
        speed = type;
        if (type == 40 || type == 80 || type == 160 ||
            type == 320) {