]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: Remove unnecessary call to irq_find_mapping
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Fri, 19 Oct 2018 08:59:57 +0000 (09:59 +0100)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 31 Oct 2018 23:33:14 +0000 (23:33 +0000)
irq_create_mapping calls irq_find_mapping internally and will use the
found mapping if one exists, so there is no need to manually call this
from i2c_smbus_host_notify_to_irq.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-core-base.c

index dc78aa7369def416898f0a4c514fd017c147f0c0..656f0a6fe3adf6917996c48fffef71bc3700351f 100644 (file)
@@ -306,10 +306,7 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
        if (client->flags & I2C_CLIENT_TEN)
                return -EINVAL;
 
-       irq = irq_find_mapping(adap->host_notify_domain, client->addr);
-       if (!irq)
-               irq = irq_create_mapping(adap->host_notify_domain,
-                                        client->addr);
+       irq = irq_create_mapping(adap->host_notify_domain, client->addr);
 
        return irq > 0 ? irq : -ENXIO;
 }