]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
thermal: fix ptr_ret.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Thu, 21 Apr 2016 01:04:01 +0000 (09:04 +0800)
committerEduardo Valentin <edubezval@gmail.com>
Tue, 17 May 2016 14:28:31 +0000 (07:28 -0700)
drivers/thermal/tango_thermal.c:86:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/tango_thermal.c

index d6592bfbd05795a8661630f8939ac05195d67994..22f9b1e92db14d0098faa1ab19ed1185f73ca6f7 100644 (file)
@@ -83,10 +83,7 @@ static int tango_thermal_probe(struct platform_device *pdev)
        writel(CMD_ON, priv->base + TEMPSI_CMD);
 
        tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
-       if (IS_ERR(tzdev))
-               return PTR_ERR(tzdev);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(tzdev);
 }
 
 static const struct of_device_id tango_sensor_ids[] = {