]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
video: ocfb: Use devm_platform_ioremap_resource() in ocfb_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 19 Sep 2019 14:26:56 +0000 (16:26 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 3 Jan 2020 13:27:49 +0000 (14:27 +0100)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/61b75aa6-ff92-e0ed-53f2-50a95d93d1f6@web.de
drivers/video/fbdev/ocfb.c

index c8cee2d890dc09082f9cd451755635e0d73d761c..bfa4ed42114864c6534c48d353964db43cdd72d8 100644 (file)
@@ -297,7 +297,6 @@ static int ocfb_probe(struct platform_device *pdev)
 {
        int ret = 0;
        struct ocfb_dev *fbdev;
-       struct resource *res;
        int fbsize;
 
        fbdev = devm_kzalloc(&pdev->dev, sizeof(*fbdev), GFP_KERNEL);
@@ -319,13 +318,7 @@ static int ocfb_probe(struct platform_device *pdev)
        ocfb_init_var(fbdev);
        ocfb_init_fix(fbdev);
 
-       /* Request I/O resource */
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "I/O resource request failed\n");
-               return -ENXIO;
-       }
-       fbdev->regs = devm_ioremap_resource(&pdev->dev, res);
+       fbdev->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(fbdev->regs))
                return PTR_ERR(fbdev->regs);