Staging: atomisp: kfreeing a devm allocated pointer

We shouldn't pass devm allocated pointers to kfree() or it leads to a
double free.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c b/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c
index 242e934a60308363a0820a61d67b585ea6a39d36..b11f90c5960cfe5231d900ed74d70b7560539e0a 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c
+++ b/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c
@@ -69,7 +69,6 @@ void *brcc064_otp_read(struct v4l2_subdev *sd, u8 dev_addr,
 
                r = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg));
                if (r != ARRAY_SIZE(msg)) {
-                       kfree(buffer);
                        dev_err(&client->dev, "read failed at 0x%03x\n", addr);
                        return NULL;
                }

diff --git a/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c b/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c
index ce4e7ab7781c6a9b26d5c5d3998155f85611d2e7..73d041f978110bcba68b9360a3712b1d8dcaaa81 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c
+++ b/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c
@@ -79,7 +79,6 @@ void *e2prom_otp_read(struct v4l2_subdev *sd, u8 dev_addr,
 
                r = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg));
                if (r != ARRAY_SIZE(msg)) {
-                       kfree(buffer);
                        dev_err(&client->dev, "read failed at 0x%03x\n", addr);
                        return NULL;
                }