]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio: pca953x: correct type of reg_direction
authorDavid Jander <david@protonic.nl>
Tue, 27 Aug 2019 06:46:28 +0000 (06:46 +0000)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 28 Aug 2019 10:55:24 +0000 (12:55 +0200)
The type of reg_direction needs to match the type of the regmap, which
is u8.

Fixes: 0f25fda840a9 ("gpio: pca953x: Zap ad-hoc reg_direction cache")
Cc: Cc: <stable@vger.kernel.org>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-pca953x.c

index 378b206d2dc9495dc32c3ffc6fdf06e35262a31e..30072a570bc277aa1ce38d94d84b5eb7e1ab8bdd 100644 (file)
@@ -604,7 +604,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d)
        u8 new_irqs;
        int level, i;
        u8 invert_irq_mask[MAX_BANK];
-       int reg_direction[MAX_BANK];
+       u8 reg_direction[MAX_BANK];
 
        regmap_bulk_read(chip->regmap, chip->regs->direction, reg_direction,
                         NBANK(chip));
@@ -679,7 +679,7 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, u8 *pending)
        bool pending_seen = false;
        bool trigger_seen = false;
        u8 trigger[MAX_BANK];
-       int reg_direction[MAX_BANK];
+       u8 reg_direction[MAX_BANK];
        int ret, i;
 
        if (chip->driver_data & PCA_PCAL) {
@@ -768,7 +768,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
 {
        struct i2c_client *client = chip->client;
        struct irq_chip *irq_chip = &chip->irq_chip;
-       int reg_direction[MAX_BANK];
+       u8 reg_direction[MAX_BANK];
        int ret, i;
 
        if (!client->irq)