]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
soc: fsl: dpio: fix memory leak of a struct qbman on error exit path
authorColin Ian King <colin.king@canonical.com>
Tue, 19 Feb 2019 14:05:17 +0000 (14:05 +0000)
committerLi Yang <leoyang.li@nxp.com>
Tue, 19 Feb 2019 20:59:39 +0000 (14:59 -0600)
Currently the error check for a null reg leaks a struct qbman
that was allocated earlier. Fix this by kfree'ing p on the error exit
path.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
drivers/soc/fsl/dpio/qbman-portal.c

index 0bddb85c0ae54c37c3d37dee7787e0f39efeb1e8..5a73397ae79e8e4b19944a7ccb634361ef8c58ea 100644 (file)
@@ -180,6 +180,7 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d)
        reg = qbman_read_register(p, QBMAN_CINH_SWP_CFG);
        if (!reg) {
                pr_err("qbman: the portal is not enabled!\n");
+               kfree(p);
                return NULL;
        }