]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mmc: sdhci-pci: Do not set DMA mask in enable_dma()
authorAlexandre Courbot <acourbot@nvidia.com>
Mon, 7 Mar 2016 02:07:57 +0000 (11:07 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 18 Mar 2016 08:12:25 +0000 (09:12 +0100)
DMA mask will already be set by sdhci_set_dma_mask(), which
is equivalent to the removed code since pci_set_dma_mask()
expands to its DMA-API counterpart.

There should also be no reason to set the DMA mask after probe.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pci-core.c

index df3b8eced8c4a50a727774404a066086d4ebe0f7..62aa5d0efceecc81c79f36806c91386a37502ff7 100644 (file)
@@ -1302,7 +1302,6 @@ static int sdhci_pci_enable_dma(struct sdhci_host *host)
 {
        struct sdhci_pci_slot *slot;
        struct pci_dev *pdev;
-       int ret = -1;
 
        slot = sdhci_priv(host);
        pdev = slot->chip->pdev;
@@ -1314,20 +1313,6 @@ static int sdhci_pci_enable_dma(struct sdhci_host *host)
                        "doesn't fully claim to support it.\n");
        }
 
-       if (host->flags & SDHCI_USE_64_BIT_DMA) {
-               if (host->quirks2 & SDHCI_QUIRK2_BROKEN_64_BIT_DMA) {
-                       host->flags &= ~SDHCI_USE_64_BIT_DMA;
-               } else {
-                       ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
-                       if (ret)
-                               dev_warn(&pdev->dev, "Failed to set 64-bit DMA mask\n");
-               }
-       }
-       if (ret)
-               ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
-       if (ret)
-               return ret;
-
        pci_set_master(pdev);
 
        return 0;