scsi: bfa: Use zeroing allocator rather than allocator/memset

Use vzalloc instead of vmalloc followed by memset 0.

Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Anil Gurumurthy <anil.gurumurthy@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index bac18f68759a06d822c0c44c332dda75edb3dc0e..bd7e6a6fc1f184e0b0065408864e7199d0adb46b 100644 (file)
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -610,13 +610,12 @@ bfad_hal_mem_alloc(struct bfad_s *bfad)
        /* Iterate through the KVA meminfo queue */
        list_for_each(km_qe, &kva_info->qe) {
                kva_elem = (struct bfa_mem_kva_s *) km_qe;
-               kva_elem->kva = vmalloc(kva_elem->mem_len);
+               kva_elem->kva = vzalloc(kva_elem->mem_len);
                if (kva_elem->kva == NULL) {
                        bfad_hal_mem_release(bfad);
                        rc = BFA_STATUS_ENOMEM;
                        goto ext;
                }
-               memset(kva_elem->kva, 0, kva_elem->mem_len);
        }
 
        /* Iterate through the DMA meminfo queue */

diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c
index 05f523971348a85d25abf39bc7ed4638471e2ae0..349cfe7d055eb3fb615841b5ab36f1ba37e106bc 100644 (file)
--- a/drivers/scsi/bfa/bfad_debugfs.c
+++ b/drivers/scsi/bfa/bfad_debugfs.c
@@ -81,7 +81,7 @@ bfad_debugfs_open_fwtrc(struct inode *inode, struct file *file)
 
        fw_debug->buffer_len = sizeof(struct bfa_trc_mod_s);
 
-       fw_debug->debug_buffer = vmalloc(fw_debug->buffer_len);
+       fw_debug->debug_buffer = vzalloc(fw_debug->buffer_len);
        if (!fw_debug->debug_buffer) {
                kfree(fw_debug);
                printk(KERN_INFO "bfad[%d]: Failed to allocate fwtrc buffer\n",
@@ -89,8 +89,6 @@ bfad_debugfs_open_fwtrc(struct inode *inode, struct file *file)
                return -ENOMEM;
        }
 
-       memset(fw_debug->debug_buffer, 0, fw_debug->buffer_len);
-
        spin_lock_irqsave(&bfad->bfad_lock, flags);
        rc = bfa_ioc_debug_fwtrc(&bfad->bfa.ioc,
                        fw_debug->debug_buffer,
@@ -125,7 +123,7 @@ bfad_debugfs_open_fwsave(struct inode *inode, struct file *file)
 
        fw_debug->buffer_len = sizeof(struct bfa_trc_mod_s);
 
-       fw_debug->debug_buffer = vmalloc(fw_debug->buffer_len);
+       fw_debug->debug_buffer = vzalloc(fw_debug->buffer_len);
        if (!fw_debug->debug_buffer) {
                kfree(fw_debug);
                printk(KERN_INFO "bfad[%d]: Failed to allocate fwsave buffer\n",
@@ -133,8 +131,6 @@ bfad_debugfs_open_fwsave(struct inode *inode, struct file *file)
                return -ENOMEM;
        }
 
-       memset(fw_debug->debug_buffer, 0, fw_debug->buffer_len);
-
        spin_lock_irqsave(&bfad->bfad_lock, flags);
        rc = bfa_ioc_debug_fwsave(&bfad->bfa.ioc,
                        fw_debug->debug_buffer,