]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"
authorAndy Lutomirski <luto@kernel.org>
Thu, 20 Apr 2017 20:37:56 +0000 (13:37 -0700)
committerJens Axboe <axboe@fb.com>
Thu, 20 Apr 2017 20:42:10 +0000 (14:42 -0600)
There's a report that it malfunctions with APST on.

See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184

Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/core.c

index 00b2818dac315bf5c35c9ec81856ebfaacc181bf..eeb409c287b8ed304bdafea7804619dfb39d15b5 100644 (file)
@@ -1395,6 +1395,15 @@ struct nvme_core_quirk_entry {
 };
 
 static const struct nvme_core_quirk_entry core_quirks[] = {
+       {
+               /*
+                * This Toshiba device seems to die using any APST states.  See:
+                * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184/comments/11
+                */
+               .vid = 0x1179,
+               .mn = "THNSF5256GPUK TOSHIBA",
+               .quirks = NVME_QUIRK_NO_APST,
+       }
 };
 
 /* match is null-terminated but idstr is space-padded. */