RDMA/core: Delete RoCE GID in hw when corresponding IP is deleted

Currently a RoCE GID entry is removed from the hardware when all
references to the GID entry drop to zero. This is a change in behavior
from before the fixed patch. The GID entry should be removed from the
hardware when GID entry deletion is requested. This allows the driver
terminate ongoing traffic through the RoCE GID.

While a GID is deleted from the hardware, GID slot in the software GID
cache is not freed. GID slot is freed once all references of such GID are
dropped. This continue to ensure that such GID slot of hardware is not
allocated to new GID entry allocation request. It is allocated once all
references to GID entry drop.

This approach allows drivers to put a tombestone of some kind on the HW
GID index to block the traffic.

Fixes: b150c3862d21 ("IB/core: Introduce GID entry reference counts")
Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 22e20ed5a3939b56d88a5d1039d36e143bd25a51..7b04590f307f52c3453a5410d9decc7e25fb175b 100644 (file)
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -215,10 +215,6 @@ static void free_gid_entry_locked(struct ib_gid_table_entry *entry)
        dev_dbg(&device->dev, "%s port=%d index=%d gid %pI6\n", __func__,
                port_num, entry->attr.index, entry->attr.gid.raw);
 
-       if (rdma_cap_roce_gid_table(device, port_num) &&
-           entry->state != GID_TABLE_ENTRY_INVALID)
-               device->ops.del_gid(&entry->attr, &entry->context);
-
        write_lock_irq(&table->rwlock);
 
        /*
@@ -364,6 +360,9 @@ static void del_gid(struct ib_device *ib_dev, u8 port,
                table->data_vec[ix] = NULL;
        write_unlock_irq(&table->rwlock);
 
+       if (rdma_cap_roce_gid_table(ib_dev, port))
+               ib_dev->ops.del_gid(&entry->attr, &entry->context);
+
        put_gid_entry_locked(entry);
 }