]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
leds: bcm6328: Use devm_platform_ioremap_resource() in bcm6328_leds_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 20 Sep 2019 12:30:31 +0000 (14:30 +0200)
committerPavel <pavel@ucw.cz>
Sun, 3 Nov 2019 16:37:19 +0000 (17:37 +0100)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-bcm6328.c

index c50d34e2b09839f7a2e456d87b08395a273a5b05..42e1b7598c3afdf3aaaef02f8b3e095673c820e2 100644 (file)
@@ -346,16 +346,11 @@ static int bcm6328_leds_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct device_node *np = pdev->dev.of_node;
        struct device_node *child;
-       struct resource *mem_r;
        void __iomem *mem;
        spinlock_t *lock; /* memory lock */
        unsigned long val, *blink_leds, *blink_delay;
 
-       mem_r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!mem_r)
-               return -EINVAL;
-
-       mem = devm_ioremap_resource(dev, mem_r);
+       mem = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(mem))
                return PTR_ERR(mem);