]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
bus: vexpress-config: fix device reference leak
authorJohan Hovold <johan@kernel.org>
Wed, 16 Nov 2016 17:31:30 +0000 (17:31 +0000)
committerArnd Bergmann <arnd@arndb.de>
Wed, 30 Nov 2016 22:29:37 +0000 (23:29 +0100)
Make sure to drop the reference to the parent device taken by
class_find_device() after populating the bus.

Fixes: 3b9334ac835b ("mfd: vexpress: Convert custom func API to regmap")
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/bus/vexpress-config.c

index 9efdf1de4035e226825c8435f72f07e8055584d2..493e7b9fc81357bc7366539cc4a8eaf22413be7f 100644 (file)
@@ -171,6 +171,7 @@ static int vexpress_config_populate(struct device_node *node)
 {
        struct device_node *bridge;
        struct device *parent;
+       int ret;
 
        bridge = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
        if (!bridge)
@@ -182,7 +183,11 @@ static int vexpress_config_populate(struct device_node *node)
        if (WARN_ON(!parent))
                return -ENODEV;
 
-       return of_platform_populate(node, NULL, NULL, parent);
+       ret = of_platform_populate(node, NULL, NULL, parent);
+
+       put_device(parent);
+
+       return ret;
 }
 
 static int __init vexpress_config_init(void)