]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo
authorMeng Xu <mengxu.gatech@gmail.com>
Wed, 20 Sep 2017 15:13:51 +0000 (11:13 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 25 Sep 2017 23:21:01 +0000 (19:21 -0400)
Since right after the user copy, we are going to memset(&karg, 0,
sizeof(karg)), the copy_from_user is redundant

Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_ctl.c

index bdffb692bded453145765ab08aefa483122a0b6f..d448fedca3b923dfb9ac10b9970f8a10eef52cd6 100644 (file)
@@ -1065,12 +1065,6 @@ _ctl_getiocinfo(struct MPT3SAS_ADAPTER *ioc, void __user *arg)
 {
        struct mpt3_ioctl_iocinfo karg;
 
-       if (copy_from_user(&karg, arg, sizeof(karg))) {
-               pr_err("failure at %s:%d/%s()!\n",
-                   __FILE__, __LINE__, __func__);
-               return -EFAULT;
-       }
-
        dctlprintk(ioc, pr_info(MPT3SAS_FMT "%s: enter\n", ioc->name,
            __func__));