]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: greybus: add missing includes
authorRui Miguel Silva <rui.silva@linaro.org>
Tue, 27 Aug 2019 15:53:02 +0000 (16:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Aug 2019 17:03:12 +0000 (19:03 +0200)
Before moving greybus core out of staging and moving header files to
include/linux some greybus header files were missing the necessary
includes. This would trigger compilation faillures with some example
errors logged bellow for with CONFIG_KERNEL_HEADER_TEST=y.

So, add the necessary headers to compile clean before relocating the
header files.

./include/linux/greybus/hd.h:23:50: error: unknown type name 'u16'
  int (*cport_disable)(struct gb_host_device *hd, u16 cport_id); ^~~
./include/linux/greybus/greybus_protocols.h:1314:2: error: unknown type name '__u8'
  __u8 data[0];
  ^~~~
./include/linux/greybus/hd.h:24:52: error: unknown type name 'u16'
  int (*cport_connected)(struct gb_host_device *hd, u16 cport_id); ^~~
./include/linux/greybus/hd.h:25:48: error: unknown type name 'u16'
  int (*cport_flush)(struct gb_host_device *hd, u16 cport_id); ^~~
./include/linux/greybus/hd.h:26:51: error: unknown type name 'u16'
  int (*cport_shutdown)(struct gb_host_device *hd, u16 cport_id, ^~~
./include/linux/greybus/hd.h:27:5: error: unknown type name 'u8'
u8 phase, unsigned int timeout);
     ^~
./include/linux/greybus/hd.h:28:50: error: unknown type name 'u16'
  int (*cport_quiesce)(struct gb_host_device *hd, u16 cport_id, ^~~
./include/linux/greybus/hd.h:29:5: error: unknown type name 'size_t'
     size_t peer_space, unsigned int timeout);
     ^~~~~~
./include/linux/greybus/hd.h:29:5: note: 'size_t' is defined in header '<stddef.h>'; did you forget to '#include <stddef.h>'?
./include/linux/greybus/hd.h:1:1:
+#include <stddef.h>
 /* SPDX-License-Identifier: GPL-2.0 */
./include/linux/greybus/hd.h:29:5:
     size_t peer_space, unsigned int timeout);
     ^~~~~~
./include/linux/greybus/hd.h:30:48: error: unknown type name 'u16'
  int (*cport_clear)(struct gb_host_device *hd, u16 cport_id); ^~~
./include/linux/greybus/hd.h:32:49: error: unknown type name 'u16'
  int (*message_send)(struct gb_host_device *hd, u16 dest_cport_id, ^~~
./include/linux/greybus/hd.h:33:32: error: unknown type name 'gfp_t'
struct gb_message *message, gfp_t gfp_mask); ^~~~~
./include/linux/greybus/hd.h:35:55: error: unknown type name 'u16'
  int (*latency_tag_enable)(struct gb_host_device *hd, u16 cport_id);

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Gao Xiang <hsiangkao@aol.com>
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20190827155302.25704-1-rui.silva@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/greybus/bundle.h
include/linux/greybus/connection.h
include/linux/greybus/control.h
include/linux/greybus/greybus_manifest.h
include/linux/greybus/greybus_protocols.h
include/linux/greybus/hd.h
include/linux/greybus/interface.h
include/linux/greybus/manifest.h
include/linux/greybus/module.h
include/linux/greybus/operation.h
include/linux/greybus/svc.h

index 8734d2055657bf398ecdbe6ca12c1f82df4bc8e1..df8d88424cb7f177f6389ccb87cb20a21adc4bbc 100644 (file)
@@ -9,7 +9,10 @@
 #ifndef __BUNDLE_H
 #define __BUNDLE_H
 
+#include <linux/types.h>
 #include <linux/list.h>
+#include <linux/pm_runtime.h>
+#include <linux/device.h>
 
 #define        BUNDLE_ID_NONE  U8_MAX
 
index 5ca3befc06360194829d82fc1a3b01bdd080dde8..d59b7fc1de3e10e585e966c0633276f813e6f07a 100644 (file)
@@ -9,8 +9,11 @@
 #ifndef __CONNECTION_H
 #define __CONNECTION_H
 
+#include <linux/bits.h>
 #include <linux/list.h>
 #include <linux/kfifo.h>
+#include <linux/kref.h>
+#include <linux/workqueue.h>
 
 #define GB_CONNECTION_FLAG_CSD         BIT(0)
 #define GB_CONNECTION_FLAG_NO_FLOWCTRL BIT(1)
index 3a29ec05f63160eddbde6fed72d38463a6112781..da11fe87165345010cbffb5f3ee57c985aba6e06 100644 (file)
@@ -9,6 +9,9 @@
 #ifndef __CONTROL_H
 #define __CONTROL_H
 
+#include <linux/types.h>
+#include <linux/device.h>
+
 struct gb_control {
        struct device dev;
        struct gb_interface *intf;
index db68f7e7d5a7c6a4b0cc1660c2eba30105a1541c..6e62fe478712230698422175e55b237047633f0d 100644 (file)
@@ -14,6 +14,9 @@
 #ifndef __GREYBUS_MANIFEST_H
 #define __GREYBUS_MANIFEST_H
 
+#include <linux/bits.h>
+#include <linux/types.h>
+
 enum greybus_descriptor_type {
        GREYBUS_TYPE_INVALID            = 0x00,
        GREYBUS_TYPE_INTERFACE          = 0x01,
index 5f34d1effb59f9280977d38cd63e4f7b741b1ed6..dfbc6c39a74b37a75fcb31dd3ed70c0b6a0fa2f8 100644 (file)
@@ -7,6 +7,8 @@
 #ifndef __GREYBUS_PROTOCOLS_H
 #define __GREYBUS_PROTOCOLS_H
 
+#include <linux/types.h>
+
 /* Fixed IDs for control/svc protocols */
 
 /* SVC switch-port device ids */
index 348b76fabc9a0ec4fb6f56b422ea5c5c2711725b..d3faf0c1a56965c961f3dd28253167ab29a69c7d 100644 (file)
@@ -9,6 +9,9 @@
 #ifndef __HD_H
 #define __HD_H
 
+#include <linux/types.h>
+#include <linux/device.h>
+
 struct gb_host_device;
 struct gb_message;
 
index 8fb1eacda3028b330265b6778e3f6a545d849285..ce4def881e6fd04135efa3ab6d7a5d7aedb68726 100644 (file)
@@ -9,6 +9,9 @@
 #ifndef __INTERFACE_H
 #define __INTERFACE_H
 
+#include <linux/types.h>
+#include <linux/device.h>
+
 enum gb_interface_type {
        GB_INTERFACE_TYPE_INVALID = 0,
        GB_INTERFACE_TYPE_UNKNOWN,
index 88aa7e44cad50c9f0c73aa8cb3970ec55b8396f9..830301b7a8bc1850ba13287476eb51ba1c87a96b 100644 (file)
@@ -9,6 +9,8 @@
 #ifndef __MANIFEST_H
 #define __MANIFEST_H
 
+#include <linux/types.h>
+
 struct gb_interface;
 bool gb_manifest_parse(struct gb_interface *intf, void *data, size_t size);
 
index 2a27e520ee94be39f80746faf918732a8f2bedcc..47b839af145d4d5e14ef323efef6bd4b89548e2b 100644 (file)
@@ -9,6 +9,9 @@
 #ifndef __MODULE_H
 #define __MODULE_H
 
+#include <linux/types.h>
+#include <linux/device.h>
+
 struct gb_module {
        struct device dev;
        struct gb_host_device *hd;
index 17ba3daf111b8068f6af65a8b9a7ae817cb9be0e..8ca864bba23ead44b86493ddaee9d307ff0b1338 100644 (file)
 #define __OPERATION_H
 
 #include <linux/completion.h>
+#include <linux/kref.h>
+#include <linux/timer.h>
+#include <linux/types.h>
+#include <linux/workqueue.h>
+
 
 struct gb_operation;
 
index e7452057cfe4acbe503be8aeeccd73685d71840a..507f8bd4e4c8102c2785165588f5cdf2325b6d9e 100644 (file)
@@ -9,6 +9,9 @@
 #ifndef __SVC_H
 #define __SVC_H
 
+#include <linux/types.h>
+#include <linux/device.h>
+
 #define GB_SVC_CPORT_FLAG_E2EFC                BIT(0)
 #define GB_SVC_CPORT_FLAG_CSD_N                BIT(1)
 #define GB_SVC_CPORT_FLAG_CSV_N                BIT(2)