]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: davinci: vpbe: constify vb2_ops structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 5 Aug 2017 10:47:09 +0000 (06:47 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 12:03:27 +0000 (08:03 -0400)
These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const.  Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct vb2_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/davinci/vpbe_display.c

index ca2adfa565f634deb842cf7fde9a82caf05e7a23..13d027031ff046df9201d3b0b8e46653d2dd0f96 100644 (file)
@@ -355,7 +355,7 @@ static void vpbe_stop_streaming(struct vb2_queue *vq)
        spin_unlock_irqrestore(&disp->dma_queue_lock, flags);
 }
 
-static struct vb2_ops video_qops = {
+static const struct vb2_ops video_qops = {
        .queue_setup = vpbe_buffer_queue_setup,
        .wait_prepare = vb2_ops_wait_prepare,
        .wait_finish = vb2_ops_wait_finish,