]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: lpc_eth: avoid resetting twice
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 10 Oct 2019 20:46:06 +0000 (22:46 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 Oct 2019 18:15:25 +0000 (11:15 -0700)
__lpc_eth_shutdown is called after __lpc_eth_reset but it is already
calling __lpc_eth_reset. Avoid resetting the IP twice.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/nxp/lpc_eth.c

index 141571e2ec11152797a9267c77a5f13e3b7887d3..544012a67221ac04a915441146cc2baf2b8c55a5 100644 (file)
@@ -1356,9 +1356,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
        if (!is_valid_ether_addr(ndev->dev_addr))
                eth_hw_addr_random(ndev);
 
-       /* Reset the ethernet controller */
-       __lpc_eth_reset(pldat);
-
        /* then shut everything down to save power */
        __lpc_eth_shutdown(pldat);