]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gfs2: fallocate_chunk: Always initialize struct iomap
authorAndreas Gruenbacher <agruenba@redhat.com>
Fri, 6 Jul 2018 22:05:41 +0000 (23:05 +0100)
committerAndreas Gruenbacher <agruenba@redhat.com>
Tue, 24 Jul 2018 22:06:48 +0000 (00:06 +0200)
In fallocate_chunk, always initialize the iomap before calling
gfs2_iomap_get_alloc: future changes could otherwise cause things like
iomap.flags to leak across calls.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/file.c

index f3c6d78659b1527e4594142078fc0703883a6978..6d895d39158ac0268ebffaa8eb95969cfb243cfb 100644 (file)
@@ -877,7 +877,6 @@ static int fallocate_chunk(struct inode *inode, loff_t offset, loff_t len,
        struct gfs2_inode *ip = GFS2_I(inode);
        loff_t end = offset + len;
        struct buffer_head *dibh;
-       struct iomap iomap = { };
        int error;
 
        error = gfs2_meta_inode_buffer(ip, &dibh);
@@ -893,6 +892,8 @@ static int fallocate_chunk(struct inode *inode, loff_t offset, loff_t len,
        }
 
        while (offset < end) {
+               struct iomap iomap = { };
+
                error = gfs2_iomap_get_alloc(inode, offset, end - offset,
                                             &iomap);
                if (error)