]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
firmware: arm_sdei: fix wrong of_node_put() in init function
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Fri, 21 Dec 2018 19:25:18 +0000 (19:25 +0000)
committerWill Deacon <will.deacon@arm.com>
Thu, 3 Jan 2019 18:03:53 +0000 (18:03 +0000)
After finding a "firmware" dt node arm_sdei tries to match it's
compatible string with it. To do so it's calling of_find_matching_node()
which already takes care of decreasing the refcount on the "firmware"
node. We are then incorrectly decreasing the refcount on that node
again.

This patch removes the unwarranted call to of_node_put().

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/firmware/arm_sdei.c

index 1ea71640fdc21dd6b8b96c93d1383babc6e89a33..dffb47c6b48011034e9dffd188b585213f88cb8b 100644 (file)
@@ -1017,7 +1017,6 @@ static bool __init sdei_present_dt(void)
                return false;
 
        np = of_find_matching_node(fw_np, sdei_of_match);
-       of_node_put(fw_np);
        if (!np)
                return false;