]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
qed: Delete redundant check on dcb_app priority
authorChristos Gkekas <chris.gekas@gmail.com>
Sun, 8 Oct 2017 22:46:47 +0000 (23:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Oct 2017 04:21:02 +0000 (21:21 -0700)
dcb_app priority is unsigned thus checking whether it is less than zero
is redundant.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Acked-By: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_dcbx.c

index 8f6ccc0c39e5e8682aa7ac677f576b4cdd970d6f..6e15d3c10ebf798ce1df46199e9cecc3f4727330 100644 (file)
@@ -2308,7 +2308,7 @@ static int qed_dcbnl_ieee_setapp(struct qed_dev *cdev, struct dcb_app *app)
 
        DP_VERBOSE(hwfn, QED_MSG_DCB, "selector = %d protocol = %d pri = %d\n",
                   app->selector, app->protocol, app->priority);
-       if (app->priority < 0 || app->priority >= QED_MAX_PFC_PRIORITIES) {
+       if (app->priority >= QED_MAX_PFC_PRIORITIES) {
                DP_INFO(hwfn, "Invalid priority %d\n", app->priority);
                return -EINVAL;
        }