]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mm: cleancache: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 15:21:11 +0000 (16:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 13:49:07 +0000 (15:49 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: linux-mm@kvack.org
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/cleancache.c

index 2bf12da9baa0666e6c772ede6ff63f4900106fe4..082fdda7aaa684862e498fe62fcaa265a2c0af90 100644 (file)
@@ -305,8 +305,7 @@ static int __init init_cleancache(void)
 {
 #ifdef CONFIG_DEBUG_FS
        struct dentry *root = debugfs_create_dir("cleancache", NULL);
-       if (root == NULL)
-               return -ENXIO;
+
        debugfs_create_u64("succ_gets", 0444, root, &cleancache_succ_gets);
        debugfs_create_u64("failed_gets", 0444, root, &cleancache_failed_gets);
        debugfs_create_u64("puts", 0444, root, &cleancache_puts);