]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tracing: Use SOFTIRQ_OFFSET for softirq dectection for more accurate results
authorPavankumar Kondeti <pkondeti@codeaurora.org>
Fri, 9 Dec 2016 16:20:17 +0000 (21:50 +0530)
committerSteven Rostedt <rostedt@goodmis.org>
Mon, 12 Dec 2016 18:51:02 +0000 (13:51 -0500)
The 's' flag is supposed to indicate that a softirq is running. This
can be detected by testing the preempt_count with SOFTIRQ_OFFSET.

The current code tests the preempt_count with SOFTIRQ_MASK, which
would be true even when softirqs are disabled but not serving a
softirq.

Link: http://lkml.kernel.org/r/1481300417-3564-1-git-send-email-pkondeti@codeaurora.org
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c

index 6f420d7b703ba1eb11a6782d12ef2ff39eaaa010..970aafe80b494a6eee976d9f1553f48a3a6348f9 100644 (file)
@@ -1949,7 +1949,7 @@ tracing_generic_entry_update(struct trace_entry *entry, unsigned long flags,
 #endif
                ((pc & NMI_MASK    ) ? TRACE_FLAG_NMI     : 0) |
                ((pc & HARDIRQ_MASK) ? TRACE_FLAG_HARDIRQ : 0) |
-               ((pc & SOFTIRQ_MASK) ? TRACE_FLAG_SOFTIRQ : 0) |
+               ((pc & SOFTIRQ_OFFSET) ? TRACE_FLAG_SOFTIRQ : 0) |
                (tif_need_resched() ? TRACE_FLAG_NEED_RESCHED : 0) |
                (test_preempt_need_resched() ? TRACE_FLAG_PREEMPT_RESCHED : 0);
 }