]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
selftests/bpf: fix return value comparison for tests in test_libbpf.sh
authorQuentin Monnet <quentin.monnet@netronome.com>
Sat, 20 Oct 2018 21:58:44 +0000 (22:58 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Sun, 21 Oct 2018 06:17:43 +0000 (23:17 -0700)
The return value for each test in test_libbpf.sh is compared with

    if (( $? == 0 )) ; then ...

This works well with bash, but not with dash, that /bin/sh is aliased to
on some systems (such as Ubuntu).

Let's replace this comparison by something that works on both shells.

Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_libbpf.sh

index d97dc914cd49690ab4c9953544a73117dcae6c05..156d89f1edcc490f511959316e5d6e11fc71968e 100755 (executable)
@@ -6,7 +6,7 @@ export TESTNAME=test_libbpf
 # Determine selftest success via shell exit code
 exit_handler()
 {
-       if (( $? == 0 )); then
+       if [ $? -eq 0 ]; then
                echo "selftests: $TESTNAME [PASS]";
        else
                echo "$TESTNAME: failed at file $LAST_LOADED" 1>&2