]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
regulator: twl6030: remove redundant range check min_uV > 1300000 && min_uV <= 1350000
authorColin Ian King <colin.king@canonical.com>
Fri, 24 Mar 2017 17:13:50 +0000 (17:13 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 24 Mar 2017 18:41:02 +0000 (18:41 +0000)
It has been pointed out to me that the range for vsel = 58 is actually
dead code as this is covered by an earlier check for (min_uV >= 700000)
&& (min_uV <= 1420000) so remove that check completely.

Reported-by: Alban Auzeill <alban.auzeill@sonarsource.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/twl6030-regulator.c

index 4864b9d742c0f7915cc792aaacd692c2a7f305b0..edaf93cc782390a7541ea1ec2512958fa0aea95e 100644 (file)
@@ -456,8 +456,6 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV,
                        vsel = 60;
                else if ((min_uV > 1350000) && (min_uV <= 1500000))
                        vsel = 59;
-               else if ((min_uV > 1300000) && (min_uV <= 1350000))
-                       vsel = 58;
                else
                        return -EINVAL;
                break;