]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
of/unittest: breadcrumbs to reduce pain of future maintainers
authorFrank Rowand <frank.rowand@sonymobile.com>
Sat, 14 Mar 2015 07:04:24 +0000 (00:04 -0700)
committerGrant Likely <grant.likely@linaro.org>
Sun, 29 Mar 2015 07:56:19 +0000 (08:56 +0100)
Fix warnings pointed out by checkpatch.

Checkpatch warns: externs should be avoided in .c files

Reducing pain for future maintainers - adding a comment so that anyone trying
to find where the extern data is created will be able to find it.
(grep will not find that location)

Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
drivers/of/unittest.c

index 9ecf8529fe2947d511db6f9b5214502ba41fc06e..9e4e401ff21d9ec05a90fc4494d8ff852e0600d4 100644 (file)
@@ -878,6 +878,10 @@ static int __init selftest_data_add(void)
 {
        void *selftest_data;
        struct device_node *selftest_data_node, *np;
+       /*
+        * __dtb_testcases_begin[] and __dtb_testcases_end[] are magically
+        * created by cmd_dt_S_dtb in scripts/Makefile.lib
+        */
        extern uint8_t __dtb_testcases_begin[];
        extern uint8_t __dtb_testcases_end[];
        const int size = __dtb_testcases_end - __dtb_testcases_begin;