staging: fsl-mc: bus: dpio: fix alter FQ state command

When checking the response verb, the valid bit should be masked out,
since its value flips depending on what Response Register
(RR0 /RR1) it's been read from.

Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 2a3ea29d9b433f6ef2bc747bdf41c7ab77667724..7988612aaecf324ca0274502806e32abc3421c00 100644 (file)
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -963,7 +963,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
        }
 
        /* Decode the outcome */
-       WARN_ON(r->verb != alt_fq_verb);
+       WARN_ON((r->verb & QBMAN_RESULT_MASK) != alt_fq_verb);
 
        /* Determine success or failure */
        if (unlikely(r->rslt != QBMAN_MC_RSLT_OK)) {