]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) +PTR_ERR
authorMamta Shukla <mamtashukla555@gmail.com>
Thu, 18 Oct 2018 20:48:15 +0000 (02:18 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Oct 2018 13:59:24 +0000 (15:59 +0200)
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its
better to have inlined function rather than code-opened implementation.

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181018204815.GA23390@armorer
drivers/gpu/drm/msm/adreno/a5xx_gpu.c

index ab1d9308c31146d968c5b431587b895df9d517a8..29b3d9d7d54ba6a5445bbc6c0d786fe3a1962bda 100644 (file)
@@ -1222,10 +1222,7 @@ static int a5xx_crashdumper_init(struct msm_gpu *gpu,
                SZ_1M, MSM_BO_UNCACHED, gpu->aspace,
                &dumper->bo, &dumper->iova);
 
-       if (IS_ERR(dumper->ptr))
-               return PTR_ERR(dumper->ptr);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(dumper->ptr);
 }
 
 static void a5xx_crashdumper_free(struct msm_gpu *gpu,