]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ARM: lpc3250: fix uda1380 gpio numbers
authorArnd Bergmann <arnd@arndb.de>
Wed, 10 Jan 2018 16:22:00 +0000 (17:22 +0100)
committerArnd Bergmann <arnd@arndb.de>
Mon, 15 Jan 2018 12:58:05 +0000 (13:58 +0100)
dtc warns about obviously incorrect GPIO numbers for the audio codec
on both lpc32xx boards:

arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18
arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18
arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18
arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18

It looks like the nodes are written for a different binding that combines
the GPIO number into a single number rather than a bank/number pair.
I found the right numbers on stackexchange.com, so this patch fixes
the warning and has a reasonable chance of getting things to actually
work.

Cc: stable@vger.kernel.org
Link: https://unix.stackexchange.com/questions/59497/alsa-asoc-how-to-correctly-load-devices-drivers/62217#62217
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/boot/dts/lpc3250-ea3250.dts
arch/arm/boot/dts/lpc3250-phy3250.dts

index c43adb7b4d7ca5e342f628d2890ef99c6901a5f8..58ea0a4e7afa0cf75acbbd64eebc5dbd94e25946 100644 (file)
@@ -156,8 +156,8 @@ &i2c1 {
        uda1380: uda1380@18 {
                compatible = "nxp,uda1380";
                reg = <0x18>;
-               power-gpio = <&gpio 0x59 0>;
-               reset-gpio = <&gpio 0x51 0>;
+               power-gpio = <&gpio 3 10 0>;
+               reset-gpio = <&gpio 3 2 0>;
                dac-clk = "wspll";
        };
 
index c72eb9845603a25d0968ae07730e2b6d2faa11b7..1e1c2f517a82b582b3a2e73fa7cf7d299bfc128b 100644 (file)
@@ -81,8 +81,8 @@ &i2c1 {
        uda1380: uda1380@18 {
                compatible = "nxp,uda1380";
                reg = <0x18>;
-               power-gpio = <&gpio 0x59 0>;
-               reset-gpio = <&gpio 0x51 0>;
+               power-gpio = <&gpio 3 10 0>;
+               reset-gpio = <&gpio 3 2 0>;
                dac-clk = "wspll";
        };