]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
habanalabs: improve error messages
authorOded Gabbay <oded.gabbay@gmail.com>
Wed, 27 Mar 2019 07:44:28 +0000 (09:44 +0200)
committerOded Gabbay <oded.gabbay@gmail.com>
Wed, 27 Mar 2019 07:44:28 +0000 (09:44 +0200)
This patch improves two error messages to help the user to
better understand what error occurred.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
drivers/misc/habanalabs/command_submission.c
drivers/misc/habanalabs/memory.c

index f908643f871fae84efb3a30ec6345ede71d815f6..02c48da0b64523f1181f2a87d7c24b721ce3bb0b 100644 (file)
@@ -261,7 +261,8 @@ static void cs_timedout(struct work_struct *work)
        ctx_asid = cs->ctx->asid;
 
        /* TODO: add information about last signaled seq and last emitted seq */
-       dev_err(hdev->dev, "CS %d.%llu got stuck!\n", ctx_asid, cs->sequence);
+       dev_err(hdev->dev, "User %d command submission %llu got stuck!\n",
+               ctx_asid, cs->sequence);
 
        cs_put(cs);
 
index ce1fda40a8b8112572b9a26db139c8aa6de76f8e..39788b1cf8d0536066d5338b367003d98d62958b 100644 (file)
@@ -109,7 +109,7 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args,
                                                        page_size);
                        if (!phys_pg_pack->pages[i]) {
                                dev_err(hdev->dev,
-                                       "ioctl failed to allocate page\n");
+                                       "Failed to allocate device memory (out of memory)\n");
                                rc = -ENOMEM;
                                goto page_err;
                        }