]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf ui browser: Fixup cleaning unused lines at the bottom
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 5 Apr 2018 14:43:38 +0000 (11:43 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 5 Apr 2018 14:51:28 +0000 (11:51 -0300)
Now that we can have extra title lines we should use ui_browser->rows
and not ->height when drawing lines, as well as adding
ui_browser->extra_title_lines to browser->y when cleaning unused lines
at the bottom, otherwise we end up clobbering with spaces the last line
just shown by ui_browser->refresh() routine.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the hists browser")
Link: https://lkml.kernel.org/n/tip-dfcpokt1pm5ixm8n9pxwtstz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browser.c

index d7bb2591838e901691ffaab7bfc73b6e40ebf452..4f75561424eda58ad554046ec7979924f9c7bc0d 100644 (file)
@@ -343,8 +343,8 @@ static int __ui_browser__refresh(struct ui_browser *browser)
        else
                width += 1;
 
-       SLsmg_fill_region(browser->y + row, browser->x,
-                         browser->height - row, width, ' ');
+       SLsmg_fill_region(browser->y + row + browser->extra_title_lines, browser->x,
+                         browser->rows - row, width, ' ');
 
        return 0;
 }