]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: host: fotg210: Use dma_pool_zalloc
authorVasyl Gomonovych <gomonovych@gmail.com>
Thu, 30 Nov 2017 22:05:24 +0000 (23:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Dec 2017 15:03:15 +0000 (16:03 +0100)
Replacing dma_pool_alloc and memset with a single call to dma_pool_zalloc

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fotg210-hcd.c

index 62fc955085a1534b2ade2cba9a0e2967c9357650..f3e1e7df88a5d5fb0181c94f143696b288a65804 100644 (file)
@@ -1865,11 +1865,9 @@ static struct fotg210_qh *fotg210_qh_alloc(struct fotg210_hcd *fotg210,
        qh = kzalloc(sizeof(*qh), GFP_ATOMIC);
        if (!qh)
                goto done;
-       qh->hw = (struct fotg210_qh_hw *)
-               dma_pool_alloc(fotg210->qh_pool, flags, &dma);
+       qh->hw = dma_pool_zalloc(fotg210->qh_pool, flags, &dma);
        if (!qh->hw)
                goto fail;
-       memset(qh->hw, 0, sizeof(*qh->hw));
        qh->qh_dma = dma;
        INIT_LIST_HEAD(&qh->qtd_list);
 
@@ -4121,7 +4119,7 @@ static int itd_urb_transaction(struct fotg210_iso_stream *stream,
                } else {
 alloc_itd:
                        spin_unlock_irqrestore(&fotg210->lock, flags);
-                       itd = dma_pool_alloc(fotg210->itd_pool, mem_flags,
+                       itd = dma_pool_zalloc(fotg210->itd_pool, mem_flags,
                                        &itd_dma);
                        spin_lock_irqsave(&fotg210->lock, flags);
                        if (!itd) {
@@ -4131,7 +4129,6 @@ static int itd_urb_transaction(struct fotg210_iso_stream *stream,
                        }
                }
 
-               memset(itd, 0, sizeof(*itd));
                itd->itd_dma = itd_dma;
                list_add(&itd->itd_list, &sched->td_list);
        }