]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'
authorShiva Kerdel <shiva@exdev.nl>
Tue, 15 Nov 2016 08:30:03 +0000 (09:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Nov 2016 10:01:54 +0000 (11:01 +0100)
After following a discussion about the used integer types Dan Carpenter
pointed out that 'int' types should be used over the current change to
's16'. The reason for this is to have an upper bound instead of overflowing
the 's16' so we could still remove devices.

Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Suggested-by: Stuart Yoder <stuart.yoder@nxp.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/include/mc-bus.h

index c7cad879bb304f7913eeedff6a481ef203fcbe4a..42700de94d590e8563033b431c6adf7c423164c7 100644 (file)
@@ -42,8 +42,8 @@ struct msi_domain_info;
  */
 struct fsl_mc_resource_pool {
        enum fsl_mc_pool_type type;
-       s16 max_count;
-       s16 free_count;
+       int max_count;
+       int free_count;
        struct mutex mutex;     /* serializes access to free_list */
        struct list_head free_list;
        struct fsl_mc_bus *mc_bus;