]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ARM: OMAP4+: Fix bad fallthrough for cpuidle
authorTony Lindgren <tony@atomide.com>
Mon, 7 Nov 2016 23:50:11 +0000 (16:50 -0700)
committerTony Lindgren <tony@atomide.com>
Mon, 7 Nov 2016 23:52:05 +0000 (16:52 -0700)
We don't want to fall through to a bunch of errors for retention
if PM_OMAP4_CPU_OSWR_DISABLE is not configured for a SoC.

Fixes: 6099dd37c669 ("ARM: OMAP5 / DRA7: Enable CPU RET on suspend")
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/omap-mpuss-lowpower.c

index 94428b476d8fec2c3de6ef50a9baf67467317bf9..7d62ad48c7c9dd1dfb290cdcf5d61479b081d7a9 100644 (file)
@@ -245,10 +245,9 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
                save_state = 1;
                break;
        case PWRDM_POWER_RET:
-               if (IS_PM44XX_ERRATUM(PM_OMAP4_CPU_OSWR_DISABLE)) {
+               if (IS_PM44XX_ERRATUM(PM_OMAP4_CPU_OSWR_DISABLE))
                        save_state = 0;
-                       break;
-               }
+               break;
        default:
                /*
                 * CPUx CSWR is invalid hardware state. Also CPUx OSWR