]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drivers: net: davinci_mdio: fix return value check in davinci_mdio_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 3 May 2019 11:18:59 +0000 (11:18 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 May 2019 17:17:28 +0000 (10:17 -0700)
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_mdio.c

index 11642721c1231e0580dfd3205c9baf0f97e21d0e..38b7f6d35759c5c73fb73e6eb9a8ed0ff6ee4c28 100644 (file)
@@ -398,8 +398,8 @@ static int davinci_mdio_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        data->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (IS_ERR(data->regs))
-               return PTR_ERR(data->regs);
+       if (!data->regs)
+               return -ENOMEM;
 
        davinci_mdio_init_clk(data);