]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ata: sata_dwc_460ex: remove empty libata callback
authorMans Rullgard <mans@mansr.com>
Tue, 26 Apr 2016 09:03:14 +0000 (12:03 +0300)
committerTejun Heo <tj@kernel.org>
Tue, 10 May 2016 16:29:20 +0000 (12:29 -0400)
The sata_dwc_qc_prep() does nothing.  Use the default ata_noop_qc_prep
instead.

Tested-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_dwc_460ex.c

index 2258baf126cd95b25cffcb129027660ced2c3d9a..3a9dd82ace324e9e9171e197e91d7866d494b1fb 100644 (file)
@@ -1132,27 +1132,6 @@ static unsigned int sata_dwc_qc_issue(struct ata_queued_cmd *qc)
        return 0;
 }
 
-/*
- * Function : sata_dwc_qc_prep
- * arguments : ata_queued_cmd *qc
- * Return value : None
- * qc_prep for a particular queued command
- */
-
-static void sata_dwc_qc_prep(struct ata_queued_cmd *qc)
-{
-       if ((qc->dma_dir == DMA_NONE) || (qc->tf.protocol == ATA_PROT_PIO))
-               return;
-
-#ifdef DEBUG_NCQ
-       if (qc->tag > 0)
-               dev_info(qc->ap->dev, "%s: qc->tag=%d ap->active_tag=0x%08x\n",
-                        __func__, qc->tag, qc->ap->link.active_tag);
-
-       return ;
-#endif
-}
-
 static void sata_dwc_error_handler(struct ata_port *ap)
 {
        ata_sff_error_handler(ap);
@@ -1212,7 +1191,6 @@ static struct ata_port_operations sata_dwc_ops = {
        .error_handler          = sata_dwc_error_handler,
        .hardreset              = sata_dwc_hardreset,
 
-       .qc_prep                = sata_dwc_qc_prep,
        .qc_issue               = sata_dwc_qc_issue,
 
        .scr_read               = sata_dwc_scr_read,