Fix minor imprecisions in cfg->portfwd[] bounds checking (which erred on the

side of rejecting input, not buffer overflow).

[originally from svn r5438]

diff --git a/config.c b/config.c
index 1501f6191a4872ab309307ac2a36da81921a26d9..60724cefd1b3663144696cee90acad15352bde1c 100644 (file)
--- a/config.c
+++ b/config.c
@@ -726,7 +726,7 @@ static void portfwd_handler(union control *ctrl, void *dlg,
            if (type != 'D') {
                *p++ = '\t';
                dlg_editbox_get(pfd->destbox, dlg, p,
-                               sizeof(str)-1 - (p - str));
+                               sizeof(str) - (p - str));
                if (!*p || !strchr(p, ':')) {
                    dlg_error_msg(dlg,
                                  "You need to specify a destination address\n"
@@ -741,7 +741,7 @@ static void portfwd_handler(union control *ctrl, void *dlg,
                    p++;
                p++;
            }
-           if ((p - cfg->portfwd) + strlen(str) + 2 <
+           if ((p - cfg->portfwd) + strlen(str) + 2 <=
                sizeof(cfg->portfwd)) {
                strcpy(p, str);
                p[strlen(str) + 1] = '\0';