]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ieee802154: cc2520: switch from BUG_ON() to WARN_ON() on problem
authorStefan Schmidt <stefan@osg.samsung.com>
Fri, 22 Sep 2017 12:14:04 +0000 (14:14 +0200)
committerStefan Schmidt <stefan@osg.samsung.com>
Mon, 6 Nov 2017 15:27:55 +0000 (16:27 +0100)
The check is valid but it does not warrant to crash the kernel. A
WARN_ON() is good enough here.
Found by checkpatch.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Varka Bhadram <varkabhadram@gmail.com>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
drivers/net/ieee802154/cc2520.c

index 735b9f5f9754ee00ffd885cf73078b342e7e13a0..0c89d3edf901c751a6683341e262d1cd047dee71 100644 (file)
@@ -517,7 +517,7 @@ cc2520_tx(struct ieee802154_hw *hw, struct sk_buff *skb)
        }
 
        spin_lock_irqsave(&priv->lock, flags);
-       BUG_ON(priv->is_tx);
+       WARN_ON(priv->is_tx);
        priv->is_tx = 1;
        spin_unlock_irqrestore(&priv->lock, flags);
 
@@ -643,9 +643,9 @@ cc2520_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
 
        dev_dbg(&priv->spi->dev, "trying to set channel\n");
 
-       BUG_ON(page != 0);
-       BUG_ON(channel < CC2520_MINCHANNEL);
-       BUG_ON(channel > CC2520_MAXCHANNEL);
+       WARN_ON(page != 0);
+       WARN_ON(channel < CC2520_MINCHANNEL);
+       WARN_ON(channel > CC2520_MAXCHANNEL);
 
        ret = cc2520_write_register(priv, CC2520_FREQCTRL,
                                    11 + 5 * (channel - 11));