]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/x86: intel_pmc_core: Fix file permissions for ltr_show
authorRajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
Fri, 1 Feb 2019 07:32:28 +0000 (13:02 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 21 Feb 2019 13:39:52 +0000 (15:39 +0200)
File permissions for ltr_show attribute should be similar to other
debugfs attributes created by this driver. '0644' should be used only
when there is a write operation desired such as for ltr_ignore.

Cc: "David E. Box" <david.e.box@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Fixes: 2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_pmc_core.c

index 80936e6bdc619e0a9e904f8a0acedc5c67c4cb29..125461ca2927f6928c460fbc93e4c3030ace5bbc 100644 (file)
@@ -702,7 +702,7 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
        debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,
                            &pmc_core_ltr_ignore_ops);
 
-       debugfs_create_file("ltr_show", 0644, dir, pmcdev, &pmc_core_ltr_fops);
+       debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops);
 
        if (pmcdev->map->pll_sts)
                debugfs_create_file("pll_status", 0444, dir, pmcdev,