]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: greybus: arche-platform: declare struct of_device_id as const
authorEva Rachel Retuya <eraretuya@gmail.com>
Thu, 22 Sep 2016 15:33:34 +0000 (23:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Sep 2016 12:11:45 +0000 (14:11 +0200)
Declare the arrays 'arche_platform_of_match' and 'arche_combined_id' as const.

'arche_platform_of_match' is only stored in the .of_match_table field of a
device_driver structure, which is declared as const.

'arche_combined_id' is passed to MODULE_DEVICE_TABLE. This macro does not
modify the array and therefore the array can be declared as const. Checkpatch
pointed out both issues.

WARNING: struct of_device_id should be normally const

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/arche-platform.c

index d6b36099d8ea6b190ae3cd9d882057e2cfe4d2cb..e36ee984485bfcf3aea56f777e9f7ec4c671ed02 100644 (file)
@@ -776,12 +776,12 @@ static SIMPLE_DEV_PM_OPS(arche_platform_pm_ops,
                        arche_platform_suspend,
                        arche_platform_resume);
 
-static struct of_device_id arche_platform_of_match[] = {
+static const struct of_device_id arche_platform_of_match[] = {
        { .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
        { },
 };
 
-static struct of_device_id arche_combined_id[] = {
+static const struct of_device_id arche_combined_id[] = {
        { .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
        { .compatible = "usbffff,2", },
        { },