]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i40e: remove debugfs tx_timeout support
authorLihong Yang <lihong.yang@intel.com>
Wed, 19 Dec 2018 14:45:41 +0000 (06:45 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 22 Jan 2019 15:55:22 +0000 (07:55 -0800)
The tx_timeout command from debugfs was originally intended to support
early silicon validation efforts. It is no longer needed. Thus remove it to
avoid misuse of triggering tx_timeout through debugfs.

Signed-off-by: Lihong Yang <lihong.yang@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_debugfs.c

index a20d1cf058ad472b751a59787eb79d444c9c8486..c67d485d6f99a9ea0028b8b5b7b84450f61c1891 100644 (file)
@@ -1642,30 +1642,7 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
                count = buf_tmp - i40e_dbg_netdev_ops_buf + 1;
        }
 
-       if (strncmp(i40e_dbg_netdev_ops_buf, "tx_timeout", 10) == 0) {
-               cnt = sscanf(&i40e_dbg_netdev_ops_buf[11], "%i", &vsi_seid);
-               if (cnt != 1) {
-                       dev_info(&pf->pdev->dev, "tx_timeout <vsi_seid>\n");
-                       goto netdev_ops_write_done;
-               }
-               vsi = i40e_dbg_find_vsi(pf, vsi_seid);
-               if (!vsi) {
-                       dev_info(&pf->pdev->dev,
-                                "tx_timeout: VSI %d not found\n", vsi_seid);
-               } else if (!vsi->netdev) {
-                       dev_info(&pf->pdev->dev, "tx_timeout: no netdev for VSI %d\n",
-                                vsi_seid);
-               } else if (test_bit(__I40E_VSI_DOWN, vsi->state)) {
-                       dev_info(&pf->pdev->dev, "tx_timeout: VSI %d not UP\n",
-                                vsi_seid);
-               } else if (rtnl_trylock()) {
-                       vsi->netdev->netdev_ops->ndo_tx_timeout(vsi->netdev);
-                       rtnl_unlock();
-                       dev_info(&pf->pdev->dev, "tx_timeout called\n");
-               } else {
-                       dev_info(&pf->pdev->dev, "Could not acquire RTNL - please try again\n");
-               }
-       } else if (strncmp(i40e_dbg_netdev_ops_buf, "change_mtu", 10) == 0) {
+       if (strncmp(i40e_dbg_netdev_ops_buf, "change_mtu", 10) == 0) {
                int mtu;
 
                cnt = sscanf(&i40e_dbg_netdev_ops_buf[11], "%i %i",
@@ -1733,7 +1710,6 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
                dev_info(&pf->pdev->dev, "unknown command '%s'\n",
                         i40e_dbg_netdev_ops_buf);
                dev_info(&pf->pdev->dev, "available commands\n");
-               dev_info(&pf->pdev->dev, "  tx_timeout <vsi_seid>\n");
                dev_info(&pf->pdev->dev, "  change_mtu <vsi_seid> <mtu>\n");
                dev_info(&pf->pdev->dev, "  set_rx_mode <vsi_seid>\n");
                dev_info(&pf->pdev->dev, "  napi <vsi_seid>\n");